ELE-485 remove user DWH query for test result samples#738
Merged
IDoneShaveIt merged 2 commits intoMar 6, 2023
Conversation
ELE-485 Remove user DWH query for test result samples
We want to remove the backward compatibility for querying test result samples from the users DWH. |
Contributor
|
👋 @IDoneShaveIt |
elongl
reviewed
Mar 6, 2023
| {% else %} | ||
| {% do return(elementary.agate_to_dicts([])) %} | ||
| {% endif %} | ||
| {% do return(elementary.agate_to_dicts([])) %} |
Contributor
There was a problem hiding this comment.
Why do we use agate_to_dicts here instead of return([])?
Contributor
Author
There was a problem hiding this comment.
No real reason, a changed I did when checked it and forgot it like that.
Changing
IDoneShaveIt
commented
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting the changes of #736, and removing the backcomp support for fetching test result samples from the user DWH