Upgraded 'packaging' requirement.#912
Merged
elongl merged 6 commits intoJun 4, 2023
Merged
Conversation
Contributor
|
👋 @elongl |
IDoneShaveIt
reviewed
Jun 4, 2023
| "pydantic<2.0", | ||
| "networkx>=2.3,<3", | ||
| "packaging>=20.9,<23.0", | ||
| "packaging>=20.9,<=23.1", |
Contributor
There was a problem hiding this comment.
Why do we want to use <= instead of just <
Contributor
Author
There was a problem hiding this comment.
To allow this version as well as it does work.
Contributor
There was a problem hiding this comment.
So why not < 23.2?
I think that if this is how we work with the rest of our requirements we should do the same here 🙂
Contributor
Author
There was a problem hiding this comment.
23.2 doesn't exist yet so I thought it might cause issues, but mostly, it doesn't really matter.
Also, we do have requirements that use >=.
IDoneShaveIt
approved these changes
Jun 4, 2023
…in-oss-python-package
…5-upgrade-packaging-package-version-in-oss-python-package
…5-upgrade-packaging-package-version-in-oss-python-package
elongl
deleted the
ele-995-upgrade-packaging-package-version-in-oss-python-package
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://elementary-community.slack.com/archives/C02CTC89LAX/p1685733416717949