Skip to content

Ele 966 add exposure data#941

Merged
NoyaArie merged 12 commits into
masterfrom
ele-966-add-exposure-data
Jun 26, 2023
Merged

Ele 966 add exposure data#941
NoyaArie merged 12 commits into
masterfrom
ele-966-add-exposure-data

Conversation

@NoyaArie
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Jun 14, 2023

ELE-966 Add exposures node info

DoD -

  • Based on the table node info design, we should now expose details about the dashboards like -
    • URL
    • Owners / tags
    • Label
    • description
    • meta?

@github-actions
Copy link
Copy Markdown
Contributor

👋 @NoyaArie
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

Comment thread elementary/monitor/api/models/models.py Outdated
normalized_artifact["normalized_full_path"] = self._normalize_artifact_path(
artifact
)
normalized_artifact["fully_qualified_name"] = self._fully_qualified_name(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify to fqn?

Comment thread elementary/monitor/api/models/models.py Outdated
return os.path.sep.join(splited_artifact_path)

@classmethod
def _fully_qualified_name(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And _get_fqn?

@NoyaArie NoyaArie merged commit 8332a9d into master Jun 26, 2023
@NoyaArie NoyaArie deleted the ele-966-add-exposure-data branch June 26, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants