Skip to content

ELE-1261 test management get tests should handle a list of owners #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IDoneShaveIt merged 1 commit into from
Jul 9, 2023
Merged

ELE-1261 test management get tests should handle a list of owners #987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions elementary/monitor/fetchers/test_management/test_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
TagsModel,
TestModel,
)
from elementary.utils.json_utils import unpack_and_flatten_str_to_list
from elementary.utils.json_utils import unpack_and_flatten_and_dedup_list_of_strings
from elementary.utils.log import get_logger

logger = get_logger(__name__)
Expand Down Expand Up @@ -80,7 +80,7 @@ def _format_resources(
formatted_resources = []
for resource in resources:
owners = (
unpack_and_flatten_str_to_list(resource["owners"])
unpack_and_flatten_and_dedup_list_of_strings(resource["owners"])
if resource["owners"]
else []
)
Expand Down Expand Up @@ -126,8 +126,12 @@ def get_tests(self) -> List[TestModel]:
tests = []
for test_result in test_results:
meta = json.loads(test_result["meta"])
owners = unpack_and_flatten_str_to_list(meta.get("owner", "[]"))
model_owners = unpack_and_flatten_str_to_list(test_result["model_owners"])
owners = unpack_and_flatten_and_dedup_list_of_strings(
meta.get("owner", "[]")
)
model_owners = unpack_and_flatten_and_dedup_list_of_strings(
test_result["model_owners"]
)
tags = list(set(json.loads(test_result["tags"])))
model_tags = list(set(json.loads(test_result["model_tags"])))
description = meta.get("description")
Expand Down Expand Up @@ -167,7 +171,7 @@ def get_project_owners(self) -> List[str]:
owners = owners_result["owner"]
if owners is None:
continue
owners = unpack_and_flatten_str_to_list(owners)
owners = unpack_and_flatten_and_dedup_list_of_strings(owners)
all_owners.extend(owners)
return all_owners

Expand Down