Skip to content

Ele 323 filter alerts by status#988

Merged
ellakz merged 13 commits into
masterfrom
ele-323-filter-alerts-by-status
Jul 23, 2023
Merged

Ele 323 filter alerts by status#988
ellakz merged 13 commits into
masterfrom
ele-323-filter-alerts-by-status

Conversation

@ellakz
Copy link
Copy Markdown
Contributor

@ellakz ellakz commented Jul 12, 2023

No description provided.

@ellakz ellakz requested a review from elongl July 12, 2023 11:27
@linear
Copy link
Copy Markdown

linear Bot commented Jul 12, 2023

ELE-362 Add an alert configuration option in edr monitor CLI / config to send fail and warn tests alerts in distinct slack channels

Is your feature request related to a problem? Please describe.
Today I am using edr monitor to send slack alerts after a dbt test run.
As we have lots of tests that are warnings (that we should also fix but it is not the same severity level) the slack channel is sometimes flooded with warnings alerts and it can sometimes shadow fail alerts (and cause mental load to the team).

I would love to have the possibility to use distinct slack channels for warn and fail tests.

The only solution about this subject that I found today is the configurations in dbt_project.yml:

vars:
  # Alerts configuration vars   #
  # All set to false by default #
  disable_model_alerts: false
  disable_test_alerts: false
  disable_warn_alerts: false
  disable_skipped_model_alerts: true
  disable_skipped_test_alerts: true

But that will disable warn (or fail) alerts for the whole project and I want to keep getting them but just somewhere else.

Describe the solution you'd like
I was thinking about a new option in edr monitor CLI. like edr monitor --severity fail/warn.
Or by using the existing -c / --config option and by adding the values below to the config file:

  disable_test_alerts: false
  disable_warn_alerts: false

(this seems less user friendly in my opinion)

Describe alternatives you've considered
Could not find any alternatives.

Would you be willing to contribute this feature?
Yes I'd like to contribute

@github-actions
Copy link
Copy Markdown
Contributor

👋 @ellakz
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@ellakz ellakz force-pushed the ele-323-filter-alerts-by-status branch from effaae9 to e90bda5 Compare July 12, 2023 15:52
@ellakz ellakz requested review from haritamar and removed request for elongl July 19, 2023 11:54
Comment thread elementary/monitor/api/models/models.py Outdated
@ellakz ellakz merged commit 242638e into master Jul 23, 2023
@ellakz ellakz deleted the ele-323-filter-alerts-by-status branch July 23, 2023 11:34
@ellakz ellakz linked an issue Sep 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants