Skip to content

Ele 1068 supperssion in cli#999

Merged
ellakz merged 6 commits into
masterfrom
ELE-1068-supperssion-in-cli
Jul 20, 2023
Merged

Ele 1068 supperssion in cli#999
ellakz merged 6 commits into
masterfrom
ELE-1068-supperssion-in-cli

Conversation

@ellakz
Copy link
Copy Markdown
Contributor

@ellakz ellakz commented Jul 18, 2023

No description provided.

@ellakz ellakz requested a review from haritamar July 18, 2023 11:03
@linear
Copy link
Copy Markdown

linear Bot commented Jul 18, 2023

ELE-1068 CLI should support disable / enable flags and default suppression internal

DoD -

  • CLI should support disable warnings / skipped tests / skipped models / models / source freshness / tests
  • CLI should support global alert suppression with default 24?
  • Backwards and deprecation message for the dbt package flags

@github-actions
Copy link
Copy Markdown
Contributor

👋 @ellakz
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@ellakz ellakz self-assigned this Jul 18, 2023
@ellakz ellakz requested a review from elongl July 18, 2023 11:07
Comment thread elementary/monitor/cli.py Outdated
@click.option(
"--global-suppression-interval",
type=int,
default=None,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be good to specify the default here, since users can see it in --help

@ellakz ellakz force-pushed the ELE-1068-supperssion-in-cli branch from 77480b3 to 85148bd Compare July 20, 2023 08:27
@ellakz ellakz merged commit 71ff0e3 into master Jul 20, 2023
@ellakz ellakz deleted the ELE-1068-supperssion-in-cli branch July 20, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants