Skip to content

ScanDialog: GTK4 prep#33

Merged
danirabbit merged 4 commits intomainfrom
danirabbit/scandialog-gtk4prep
Apr 15, 2026
Merged

ScanDialog: GTK4 prep#33
danirabbit merged 4 commits intomainfrom
danirabbit/scandialog-gtk4prep

Conversation

@danirabbit
Copy link
Copy Markdown
Member

  • Rename to ScanDialog so its clear what kind of object this is in other classes
  • Bump copyright header
  • Fix minor codestyle issues like whitespace
  • Use child property
  • Don't set image size, just its gicon
  • Use ScrolledWindow features instead of hardcoding size
  • Replace grid with box
  • avoid list_box.get_children ()
  • remove redundant list header

@danirabbit danirabbit requested a review from a team February 26, 2025 22:48
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Feb 26, 2025
ryonakano
ryonakano previously approved these changes Mar 1, 2025
Copy link
Copy Markdown
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpicking.

Comment thread src/Dialog/ScanDialog.vala Outdated
@ryonakano ryonakano dismissed their stale review March 1, 2025 02:37

Wrong button

Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
@ryonakano
Copy link
Copy Markdown
Member

Changes LGTM but this branch now has conflicts.

@zeebok
Copy link
Copy Markdown

zeebok commented Jan 25, 2026

Still has conflicts

@danirabbit danirabbit merged commit 575f621 into main Apr 15, 2026
4 checks passed
@danirabbit danirabbit deleted the danirabbit/scandialog-gtk4prep branch April 15, 2026 16:22
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants