Skip to content

GuestsPanel: GObject style, cleanup#926

Merged
danirabbit merged 5 commits into
masterfrom
danirabbit/guestpanel-cleanup
Feb 23, 2026
Merged

GuestsPanel: GObject style, cleanup#926
danirabbit merged 5 commits into
masterfrom
danirabbit/guestpanel-cleanup

Conversation

@danirabbit
Copy link
Copy Markdown
Member

  • Use SPDX header
  • Subclass Box instead of Grid
  • Take ICal component as construction arg instead of parent dialog. We only need the component here since EventDialog's can_edit is never set
  • Don't cache style context, makes an easier replace when we port to GTK4
  • Set properties when instantiating
  • Explicit h and v expand
  • Set mnemonic widget for "Invitees" header so the list has a label for the screen reader
  • Use child property where appropriate
  • minor code style changes

@danirabbit danirabbit requested a review from a team February 17, 2026 17:36
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Feb 17, 2026
@danirabbit danirabbit enabled auto-merge (squash) February 22, 2026 21:24
@danirabbit danirabbit merged commit 9df346c into master Feb 23, 2026
5 of 6 checks passed
@danirabbit danirabbit deleted the danirabbit/guestpanel-cleanup branch February 23, 2026 19:27
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants