SourceView: prepare context menu for GLib.Menu #1675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use GLib.Menu here yet because SourceView gives us a Gtk.Menu, but we can make sure that we're only using what's available to us in GLib.Menu so that porting will be less painful later. Also do some cleanup of strings while we're here. I can break that into a separate branch if you'd like.
action_nameinstead of manually connecting to activatesensitiveon menu items. Ideally we really should set actions enabled/disabled in the document because we also have to worry about keyboard shortcuts, but for now we can consistently use the workaround of removing the action name. Menu items with no action name will automatically be insensitive.Menu item renames: