Skip to content

SourceList: use key controller#1710

Merged
jeremypw merged 3 commits intomasterfrom
danirabbit/sourcelist-keycontroller
Apr 21, 2026
Merged

SourceList: use key controller#1710
jeremypw merged 3 commits intomasterfrom
danirabbit/sourcelist-keycontroller

Conversation

@danirabbit
Copy link
Copy Markdown
Member

No description provided.

@danirabbit danirabbit requested a review from a team April 15, 2026 16:59
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Apr 15, 2026
Copy link
Copy Markdown
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good, but in practice this feature is almost impossible to use because it hard to get keyboard focus into the sidebar. The only way I found was to start a rename using right-click and then cancel it - the keyboard focus then remains in the sidebar.

If it is intended to make the sidebar (and other widgets other than the textview and terminal) operable with the keyboard alone, in a discoverable way, then there is work to do.

@jeremypw
Copy link
Copy Markdown
Collaborator

Files uses <Control><Tab> to switch focus from view to sidebar but this does not work in Code as this shortcut is used by the textview.

@danirabbit
Copy link
Copy Markdown
Member Author

danirabbit commented Apr 20, 2026

Yeah I had a hard time testing this and I think the keyboard navigation experience definitely needs to be addressed. My goal here however is just to prepare for GTK4 porting

@jeremypw
Copy link
Copy Markdown
Collaborator

OK, it sounds like the goal is that the sidebar should be accessible/controllable with the keyboard but that can be achieved later.

@jeremypw jeremypw merged commit 58c07a8 into master Apr 21, 2026
6 checks passed
@jeremypw jeremypw deleted the danirabbit/sourcelist-keycontroller branch April 21, 2026 09:29
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants