Fix 1699#1721
Merged
Merged
Conversation
This fixes the trailing whitespace stripping behavior on save: - Excludes Markdown and YAML files where trailing whitespace can be semantically meaningful. - Adds description/subtext in the settings switch to clarify that it only applies to syntax-highlighted files, except Markdown and YAML. Fixes elementary#1698
jeremypw
approved these changes
May 24, 2026
Collaborator
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Nice concise solution! Thanks
Contributor
Author
|
@jeremypw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1699
This PR prevents trailing whitespace from being stripped inside string literals (like multiline strings). Currently,
strip_trailing_spaces()splits the buffer into lines and runs a regex match to strip whitespace on everything, which changes the semantic value of the strings.To fix this we check the context class of the iterator at the line end using
iter_has_context_class(). If the iterator has the"string"context class, we skip stripping the trailing space. this is similar to how we already skip stripping inside comments in thedetect-indentplugin.Testing
Tested this locally with multiline string literals in a test file. trailing whitespaces inside triple quotes are now preserved, while normal lines of code stil get striped corectly.