User can see close focused project folder, alphabetize folders, and collapse folders. #657

roymckenzie · 2019-03-13T09:38:58Z

@cassidyjames I've updated this branch with some of the ideas we messaged about. Specifically:

The ability to close an active / selected Project Folder.
The ability to collapse all Project Folders.
The ability to order Project Folders alphabetically.

Let me know what you think.

…ollapse folders.

tintou · 2019-03-13T09:40:31Z

Wait, shouldn't the project folder always be alphabetized?

roymckenzie · 2019-03-13T09:45:28Z

@tintou they didn't appear to be alphabetized by default. If that is something that should be done by default (probably), I can modify the add_folder method in FileView to do that and we can just remove it from the Gtk.Menu in the inline toolbar.

cassidyjames · 2019-03-13T17:15:32Z

@tintou @roymckenzie to clarify, this is about sorting the projects themselves in alphabetical order, not the contents of the projects/folders. In this case, no, they should not always be alphabetized because they're in the order they were added; you know the last-added project will always be at the bottom. However, if you've amassed a large amount of projects you're jumping between a lot, it would be nice to sort them in alphabetical order.

roymckenzie · 2019-03-15T06:51:24Z

Looking at the icon for the remove project folder action, I don't like the icon that much. It is hard to see and does not seem intuitive.

I am currently using the folder-move-symbolic icon for that.

A deeper question I have is: Does it even make since to have that button / functionality located there? The user can right-click on the project folder in the FileView to close a specific project folder. Actions on the newly proposed inline toolbar imply more general actions related to all project folders than one specific one in my opinion.

cassidyjames · 2019-03-19T12:17:26Z

@roymckenzie that's fair. It's also not clear which specific project is "selected", so removing one could be problematic imho.

roymckenzie · 2019-03-28T05:09:33Z

@cassidyjames I removed the "Close Active Folder" functionality from the inline toolbar (and this branch). Let me know what you think.

cassidyjames

Some minor changes. I also wonder… would it make sense to remove the now-redundant "open a folder" item from the headerbar?

src/Widgets/Pane.vala

cassidyjames · 2019-03-29T01:58:00Z

src/Widgets/Pane.vala

-        var add_button = new Gtk.ToolButton (new Gtk.Image.from_icon_name ("folder-open-symbolic", Gtk.IconSize.BUTTON), null);
-        add_button.action_name = Scratch.MainWindow.ACTION_PREFIX + Scratch.MainWindow.ACTION_OPEN_FOLDER;
-        add_button.tooltip_text = _("Add Project Folder…");
+        var add_folder_button = new Gtk.ToolButton (new Gtk.Image.from_icon_name ("folder-open-symbolic", Gtk.IconSize.BUTTON), null);


I see we're setting this to a symbolic icon, but for some reason it's not rendering as symbolic… any idea what's up here?

@danrabbit mentioned this is due to the stylesheet, and not something within Code.

src/Widgets/Pane.vala

Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com>

jeremypw · 2019-09-11T16:31:56Z

@roymckenzie Will you be updating this PR? There seems to be an outstanding change request. If so, you might consider incorporating the functionality of #665 (if feasible).

cassidyjames · 2019-10-03T17:51:44Z

Barring that symbolic issue, I'm personally very happy with this branch and have been using it for a while. I forgot this wasn't in master! 😅

cassidyjames · 2019-10-03T18:00:38Z

Ah, this should probably also remove the Open Folder button from the HeaderBar since it could be confusing that there are two places to do it. But I'd want to get thoughts from @elementary/ux.

cassidyjames · 2019-10-03T18:02:41Z

@roymckenzie it turns out the icon issue is actually an issue in the stylesheet, so I've reported it there.

Not an issue in this repo

jeremypw

See in line comments.
@cassidyjames : Did you still want the headerbar "add folder" button removed here? You may want to override my comments on the icons.

jeremypw · 2019-10-14T11:28:07Z

src/Widgets/Pane.vala

-        toolbar.add (add_button);
+        var project_more_button = new Gtk.MenuToolButton (null, null);
+        project_more_button.tooltip_text = _("Manage project folders…");
+


Lint: Unexpected whitespace at end of line.

jeremypw · 2019-10-14T11:29:02Z

src/Widgets/Pane.vala

-        var add_button = new Gtk.ToolButton (new Gtk.Image.from_icon_name ("folder-open-symbolic", Gtk.IconSize.BUTTON), null);
-        add_button.action_name = Scratch.MainWindow.ACTION_PREFIX + Scratch.MainWindow.ACTION_OPEN_FOLDER;
-        add_button.tooltip_text = _("Add Project Folder…");
+        var add_folder_button = new Gtk.ToolButton (new Gtk.Image.from_icon_name ("folder-open-symbolic", Gtk.IconSize.BUTTON), null);


Lint: Long line

src/Widgets/Pane.vala

jeremypw · 2019-10-14T11:51:22Z

src/Widgets/Pane.vala

+        add_folder_button.tooltip_text = _("Add Project Folder…");

-        toolbar.add (add_button);
+        var project_more_button = new Gtk.MenuToolButton (null, null);


I would expect a "open-menu" symbolic icon rather than the default down arrow which I associate with downloading or a combobox. A "hamburger" type icon would be nice but I am not sure that one is available.

I was just using the default icon which I believe is used in other similar "dropdown" contexts, but I'd be fine to change to something else. I wanted to avoid using a settings-type icon because this is not necessarily settings, it's actions. view-more-symbolic might work. Thoughts from @elementary/ux?

cassidyjames · 2019-10-15T03:24:43Z

Did you still want the headerbar "add folder" button removed here?

@jeremypw I think so, because having it in both places doesn't make a ton of sense to me (and just muddies sidebar actions with global actions). I did remove it from the HeaderBar in a commit above, but I'd be open to @elementary/ux feedback as well.

# Conflicts fixed in : # src/Widgets/Pane.vala

Stale

jeremypw · 2019-11-19T19:53:47Z

@cassidyjames I have removed the headerbar "New folder" button and used the same icon in the inline toolbar as users will be familiar with its meaning in this context.

cassidyjames · 2019-11-19T19:59:31Z

@jeremypw we should not use the non-semantic icon, the open-folder icon is more correct.

jeremypw · 2019-11-19T20:03:47Z

@cassidyjames OK. I now notice that this PR is merging into another older PR of yours anyway - I am confused as to which to work on. I probably should not have pulled in the master branch - there is now an enormous diff for some reason :-(

cassidyjames · 2019-11-19T20:15:45Z

@jeremypw ah I didn't realize that. I say we merge this into my original branch since I'm on board with the changes so far and then we can use that as the actual PR. Sorry about the mess!

* Add inline toolbar to sidebar * Remove Open Folder button from HeaderBar Since it's redundant * User can see close focused project folder, alphabetize folders, and collapse folders. (#657) * User can see close focused project folder, alphabetize folders, and collapse folders. * removed close folder icon/functionality in the inline toolbar * Update src/Widgets/Pane.vala Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com> * Update src/Widgets/Pane.vala Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com> * Update src/Widgets/Pane.vala Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com> * Update src/Widgets/Pane.vala Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com> * Move headerbar open folder button to inline toolbar * Fix lint errors * Revert icon change * Fix lint error (again)

User can see close focused project folder, alphabetize folders, and c…

b236248

…ollapse folders.

roymckenzie mentioned this pull request Mar 15, 2019

Expand/collapse all projects in sidebar #656

Closed

roymckenzie force-pushed the sidebar-inline-toolbar branch from 1b49772 to 64f90c0 Compare March 28, 2019 04:56

removed close folder icon/functionality in the inline toolbar

263b57c

roymckenzie force-pushed the sidebar-inline-toolbar branch from 64f90c0 to 263b57c Compare March 29, 2019 00:16

cassidyjames previously requested changes Mar 29, 2019

View reviewed changes

cassidyjames reviewed Mar 29, 2019

View reviewed changes

src/Widgets/Pane.vala Outdated Show resolved Hide resolved

cassidyjames reviewed Mar 29, 2019

View reviewed changes

src/Widgets/Pane.vala Outdated Show resolved Hide resolved

cassidyjames and others added 4 commits March 29, 2019 00:17

Update src/Widgets/Pane.vala

afda8bb

Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com>

Update src/Widgets/Pane.vala

3d00e5e

Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com>

Update src/Widgets/Pane.vala

bb658af

Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com>

Update src/Widgets/Pane.vala

e619a89

Co-Authored-By: roymckenzie <1065321+roymckenzie@users.noreply.github.com>

cassidyjames requested a review from a team October 3, 2019 17:51

cassidyjames mentioned this pull request Oct 3, 2019

Don't force buttons in action bars inside of sidebars to fullcolor elementary/stylesheet#553

Closed

jeremypw previously requested changes Oct 14, 2019

View reviewed changes

Jeremy Wootten added 3 commits November 19, 2019 19:45

Move headerbar open folder button to inline toolbar

fb06222

Merge https://github.com/elementary/code into sidebar-inline-toolbar

1e806bb

# Conflicts fixed in : # src/Widgets/Pane.vala

Fix lint errors

380167e

Jeremy Wootten added 3 commits November 19, 2019 20:08

Revert icon change

01c5d76

Merge branch 'sidebar-inline-toolbar' into sidebar-inline-toolbar

4fd73e2

Fix lint error (again)

c3a429d

cassidyjames merged commit 810c9b0 into elementary:sidebar-inline-toolbar Nov 19, 2019

Uh oh!

User can see close focused project folder, alphabetize folders, and collapse folders. #657

User can see close focused project folder, alphabetize folders, and collapse folders. #657

Uh oh!

Conversation

roymckenzie commented Mar 13, 2019

Uh oh!

tintou commented Mar 13, 2019

Uh oh!

roymckenzie commented Mar 13, 2019

Uh oh!

cassidyjames commented Mar 13, 2019

Uh oh!

roymckenzie commented Mar 15, 2019

Uh oh!

cassidyjames commented Mar 19, 2019

Uh oh!

roymckenzie commented Mar 28, 2019

Uh oh!

cassidyjames left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cassidyjames Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

cassidyjames Nov 19, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremypw commented Sep 11, 2019

Uh oh!

cassidyjames commented Oct 3, 2019

Uh oh!

cassidyjames commented Oct 3, 2019

Uh oh!

cassidyjames commented Oct 3, 2019

Uh oh!

jeremypw left a comment

Choose a reason for hiding this comment

Uh oh!

jeremypw Oct 14, 2019

Choose a reason for hiding this comment

Uh oh!

jeremypw Oct 14, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jeremypw Oct 14, 2019

Choose a reason for hiding this comment

Uh oh!

cassidyjames Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

cassidyjames commented Oct 15, 2019

Uh oh!

jeremypw commented Nov 19, 2019

Uh oh!

cassidyjames commented Nov 19, 2019

Uh oh!

jeremypw commented Nov 19, 2019

Uh oh!

cassidyjames commented Nov 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cassidyjames left a comment •

edited

Loading