Add close all folders except this context item #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidyjames
previously requested changes
Apr 15, 2019
Contributor
cassidyjames
left a comment
cassidyjames
left a comment
There was a problem hiding this comment.
Does this conflict with #657? It's a little different, but these two PRs should probably consider one another in their implementation. Also, small copy suggestion.
added 2 commits
November 26, 2019 11:45
# Conflicts fixed in: # src/FolderManager/ProjectFolderItem.vala
Collaborator
|
I have fixed the conflict with master and updated text according to Cassidy's recommendation. I think this option is OK here. Anywhere else it is not certain what "This folder" is. |
cassidyjames
suggested changes
Jan 16, 2020
Contributor
cassidyjames
left a comment
cassidyjames
left a comment
There was a problem hiding this comment.
Nice! Minor critique: the item should probably be marked as insensitive when it won't do anything, i.e. when only one folder is open.
cassidyjames
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a context menu item to projects in the sidebar that allows you to close all folders except the one that was right clicked on.
Useful for when you're tidying up your open projects but want to keep the one you're currently working on.