Skip to content

Window: organize and scope properties#2733

Merged
jeremypw merged 3 commits intomainfrom
danirabbit/window-organizescopeproperties
Feb 11, 2026
Merged

Window: organize and scope properties#2733
jeremypw merged 3 commits intomainfrom
danirabbit/window-organizescopeproperties

Conversation

@danirabbit
Copy link
Member

So we know what our API is here

  • public signals and properties at the top
  • Explicitly scope things (no implicit private)
  • make tab_view private set
  • Scope down widgets that don't need public access

@danirabbit danirabbit requested a review from a team February 10, 2026 18:08
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ordering mentioned in the developer docs? I was never sure what the approved order was.

@jeremypw jeremypw enabled auto-merge (squash) February 11, 2026 12:27
@jeremypw jeremypw merged commit debd7eb into main Feb 11, 2026
4 checks passed
@jeremypw jeremypw deleted the danirabbit/window-organizescopeproperties branch February 11, 2026 12:29
@danirabbit
Copy link
Member Author

@jeremypw i don't think it is documented. More just convention. I'll put together a proposal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants