Use 'folder-open' icon when folder has been opened or expanded. (#474 #148 #153)#506
Merged
danirabbit merged 11 commits intomasterfrom Jul 25, 2018
Merged
Use 'folder-open' icon when folder has been opened or expanded. (#474 #148 #153)#506danirabbit merged 11 commits intomasterfrom
danirabbit merged 11 commits intomasterfrom
Conversation
jeremypw
added
Status: In Progress
Contributor
Author
|
Regression not fully resolved. |
jeremypw
removed
the
Status: In Progress
Contributor
Author
|
Regression fixed |
jeremypw
changed the title
Member
|
Looks good UX wise :) |
added 3 commits
May 31, 2018 10:29
* Do not reference viewcontainer inside nested closure. * Close viewcontainer before creating new window, when tab moved.
# Conflicts: # src/View/Window.vala
Contributor
Author
|
The need for a long timeout no longer needed (race condition was found and fixed). Reverted to original Idle loop, which is still needed. |
danirabbit
approved these changes
Jul 25, 2018
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #474 Fixes #148 Fixes #153
Note that this PR causes the "folder-open" icon to be used if the folder is open any how. i.e if it is open in another tab or window or another Miller column or as an expanded row in list view. It relies on the GOF.Directory.Async object being removed from the cache when it is not being displayed anywhere.
In order for this to work properly it was necessary to incorporate a fix for ViewContainer destruction and this in turn required fixing a regression in dragging a tab to a new window (which was only working because the ViewContainer was not being destroyed when it should). Reluctantly a timeout had to be used to overcome a crash being caused by some undiagnosed race condition when dragging a duplicate tab out of the window.
If the "folder-open" state is to be confined to individual views, then it will be necessary to implement a more complicated solution involving adding another column to the fm-list-model which does not derive its data from a GOF file (GOF file objects are shared between views).