WindowClone: display modal dialogs on top of parent window#2805
WindowClone: display modal dialogs on top of parent window#2805
Conversation
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
This looks really cool, thank you! Just a few comments :)
| finish_drag (); | ||
| } | ||
|
|
||
| private bool filter_child_window (Object obj) requires (obj is Meta.Window) { |
There was a problem hiding this comment.
Afaict this currently introduces a memory leak since the custom filter holds a ref on us because we are the delegate target and we hold a ref on the custom filter via the window list model. Ig the cleanest way to do this is to make a gtk.filter subclass. Alternatively we could also make this method static and then set the window as glib.object.set_data on the filter so that we can get it in the static function.
There was a problem hiding this comment.
There seems to be a memory leak in main as well... But I implemented a Gtk.Filter subclass anyway. I'll take a look at the memory leak later this week
lenemter
force-pushed
the
lenemter/window-clone-children
branch
from
28270f3 to
751c32c
Compare
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Just a few more comments :)
lenemter
force-pushed
the
lenemter/window-clone-children
branch
from
af30519 to
000b949
Compare
2 participants
Closes #198
Before
After