Tests: Use a single executable#2849
Merged
Merged
Conversation
Member
Author
|
@lenemter what do you think about this? |
leolost2605
force-pushed
the
leolost/single-test-executable
branch
from
a7ce263 to
5396096
Compare
lenemter
requested changes
May 16, 2026
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
I really like the use of test_case.run! Good job. I left a comment regarding the get_test_case function
leolost2605
force-pushed
the
leolost/single-test-executable
branch
from
5396096 to
0f3e975
Compare
lenemter
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes and closes #2835
This achieves the same performance boost but makes sure the tests can only be run isolated.
Most notably having the run method an instance method of a test case makes sure of that.
I know that this might be pedantic but the meta context stuff is quite fragile and it took a while to get it working so I think having it with as many guardrails as possible is probably for the better.