ModalProxy: Explicitly allow window groups#2855
Open
leolost2605 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a non grabbed modal proxy is active we currently just allow any shell window to receive input focus.
This has the problem that e.g. when a modal window like the polkit dialog is active and then a desktop shell window tries to get focus (e.g. wingpanel reasks for your wifi password) it will give focus to that window which might not be immediately apparent. This will be especially noticeable with the lock screen so this also serves as preparation for #2854
With this PR we need to explicitly allow window groups to be able to receive focus.