Refactorings to prep for a later show_seconds PR#213
Closed
FriendOfEntropy wants to merge 12 commits intoelementary:masterfrom
Closed
Refactorings to prep for a later show_seconds PR#213FriendOfEntropy wants to merge 12 commits intoelementary:masterfrom
FriendOfEntropy wants to merge 12 commits intoelementary:masterfrom
Conversation
donadigo
requested changes
Jul 2, 2019
Collaborator
donadigo
left a comment
There was a problem hiding this comment.
Can you explain why the timepicker_with_format was added to the demo? It displays the same thing for me as the time_format. Is this something for the refactor?
Contributor
|
@danrabbit This is related to an issue you raised, so I requested a review from you. Not sure if the author is still available to work on it. |
Contributor
|
I am going to close this as the author has shown little or no activity since beginning of 2020 and no review has been forthcoming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #208
Per discussion in a previously canceled show_seconds PR, this is a set of small refactorings to limit the amount of simultaneous changes for review when a new show_seconds PR is created later.