Skip to content

Styles: make cards rounded, expand demo, new constants#765

Merged
wpkelso merged 1 commit intomainfrom
danirabbit/styles-cards
Mar 21, 2025
Merged

Styles: make cards rounded, expand demo, new constants#765
wpkelso merged 1 commit intomainfrom
danirabbit/styles-cards

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Mar 21, 2025

Screenshot from 2025-03-20 18 02 33

Turns out everywhere we use ROUNDED is with CARD and the only places we don't use rounded with card are:

  • in Files, Mail, and Photos because there's no easy way to crop overflow of images in GTK3, so this is not relevant and will be automatically fine in GTK4
  • In AppCenter and Notifications indicator because we set a custom border radius

Basically there's no cases where we actually want square cards intentionally. So I think we can just make these round by default and deprecate the rounded class

@danirabbit danirabbit requested a review from a team March 21, 2025 01:10
Copy link
Member

@wpkelso wpkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@wpkelso wpkelso merged commit dca6fc3 into main Mar 21, 2025
5 checks passed
@wpkelso wpkelso deleted the danirabbit/styles-cards branch March 21, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants