Skip to content

Add ToolBox #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 10 commits into from
May 6, 2025
Merged

Add ToolBox #776

danirabbit merged 10 commits into from
May 6, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Mar 26, 2025 •
edited
Loading

Does the least to create a ToolBox/ToolbarView widget.

  • Named ToolBox instead of ToolbarView to avoid css name collision with Adw.ToolbarView
  • Only has flat style for now since that's the most common. Will add more styles in future branches like raised, overlaid
  • You can see an example of a bottom bar if you shrink the Welcome page

@danirabbit danirabbit changed the title Add ToolbarView Add ToolBox Apr 17, 2025
@danirabbit danirabbit requested a review from a team April 17, 2025 19:38
@danirabbit danirabbit marked this pull request as ready for review April 17, 2025 19:39
@danirabbit danirabbit added this to OS 9 Apr 19, 2025
@danirabbit danirabbit moved this to Needs Review in OS 9 Apr 19, 2025
leolost2605
leolost2605 reviewed May 4, 2025
View reviewed changes
@danirabbit danirabbit enabled auto-merge (squash) May 6, 2025 20:11
@danirabbit danirabbit merged commit 1f5c098 into main May 6, 2025
5 checks passed
@danirabbit danirabbit deleted the danirabbit/toolbarview branch May 6, 2025 20:12
@github-project-automation github-project-automation bot moved this from Needs Review to Done in OS 9 May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leolost2605 leolost2605 leolost2605 left review comments

@zeebok zeebok zeebok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

OS 9
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danirabbit @zeebok @leolost2605