Skip to content

pantheon: Add Maps#144

Merged
danirabbit merged 1 commit into
noblefrom
ryonakano/pantheon-add-maps
Jul 16, 2025
Merged

pantheon: Add Maps#144
danirabbit merged 1 commit into
noblefrom
ryonakano/pantheon-add-maps

Conversation

@ryonakano
Copy link
Copy Markdown
Member

@danirabbit
Copy link
Copy Markdown
Member

danirabbit commented Jul 15, 2025

I suppose we need to wait until we publish to stable channel or do we have different packages for that?

@ryonakano
Copy link
Copy Markdown
Member Author

I don't think we need to wait until we publish to stable channel.

I've created separated recipes for Daily and Stable and built only on daily:

https://code.launchpad.net/~elementary-os/+recipe/maps-daily
https://code.launchpad.net/~elementary-os/+recipe/maps-stable

IIRC packages that are not available are just ignored by Germinate so I suppose it's fine to merge this. Then Maps should be pulled on existing Daily installations and preinstalled on new Daily builds, while it would not be pulled and preinstalled on Stable which has no matching package for io.elementary.maps at the moment.

@ryonakano
Copy link
Copy Markdown
Member Author

Monitor (added in #142) is also not yet published to Stable but only pulled on Daily as expected.

@danirabbit
Copy link
Copy Markdown
Member

Ah I meant the Flatpak is being published to daily but not yet to stable. So the post-install script would fail unless we have a separate daily packaging branch with a post-install that pulls from the daily Flatpak channel

@ryonakano
Copy link
Copy Markdown
Member Author

ryonakano commented Jul 16, 2025

Created deb-packaging-daily branch on Maps and committed elementary/maps@559e04b (assuming rebase on deb-packaging branch every time we pushes changes there).

Requested build on Launchpad with deb-packaging-daily branch and now I'm waiting for the build and upload succeeds: https://code.launchpad.net/~elementary-os/+recipe/maps-daily

ryo@b760m-host:~/work/elementary/maps (deb-packaging-daily)$ git show
commit 559e04b5c74bbe89aab8c9c3ac4f566db9f016b8 (HEAD -> deb-packaging-daily, origin/deb-packaging-daily)
Author: Ryo Nakano <ryonakaknock3@gmail.com>
Date:   Wed Jul 16 21:37:57 2025 +0900

    Install/uninstall Maps from daily Flatpak channel

    Maps is being published to daily but not yet to stable at the moment.
    So the post-install and pre-uninstall scripts would fail unless
    we have a separate daily packaging branch with a post-install/pre-uninstall
    that handles with the daily Flatpak channel.

diff --git a/debian/postinst b/debian/postinst
index c8a6037..7eb7fc2 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -3,7 +3,7 @@
 set -e

 flatpak remote-add --if-not-exists --system appcenter https://flatpak.elementary.io/repo.flatpakrepo
-flatpak install --system --noninteractive appcenter io.elementary.maps//stable || true
+flatpak install --system --noninteractive appcenter io.elementary.maps//daily || true

 #DEBHELPER#

diff --git a/debian/prerm b/debian/prerm
index 4dfa50a..351e9ba 100644
--- a/debian/prerm
+++ b/debian/prerm
@@ -2,7 +2,7 @@

 set -e

-flatpak remove --system --noninteractive io.elementary.maps//stable || true
+flatpak remove --system --noninteractive io.elementary.maps//daily || true

 #DEBHELPER#

ryo@b760m-host:~/work/elementary/maps (deb-packaging-daily)$

@danirabbit danirabbit merged commit a0634da into noble Jul 16, 2025
@danirabbit danirabbit deleted the ryonakano/pantheon-add-maps branch July 16, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants