Skip to content

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 9, 2024

Changes from #377

Screenshot from 2024-01-09 12 44 29

  • Use light/dark style images from Onboarding and use your wallpaper
  • Create them in a way that's more compatible with GTK 4 and relying on CSS for sizing
  • Replace grid with box
  • set mnemonic widget

@danirabbit danirabbit requested a review from a team January 9, 2024 20:28
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background does not reflect truth if the user is using a plain color wallpaper rather than an image.

@danirabbit
Copy link
Member Author

@jeremypw ah yup. I'll revert the wallpaper part for now and follow up in another branch so I'm not blocking with that

@danirabbit danirabbit requested a review from jeremypw January 10, 2024 17:39
@jeremypw jeremypw merged commit 877c08e into master Jan 10, 2024
@jeremypw jeremypw deleted the danirabbit/appearance-gtk4prep branch January 10, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants