Conversation
leolost2605
reviewed
Feb 22, 2026
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
LGTM only a comment regarding the filter func
src/Views/Text.vala
Outdated
|
|
||
| construct { | ||
| var default_font_dialog = new Gtk.FontDialog () { | ||
| filter = new Gtk.CustomFilter ((item) => { |
Member
There was a problem hiding this comment.
I'm not sure whether vala captures the self even if it's not used but I think it does? We can get around this by making it a static function though (as opposed to signal connections that can be object methods other callbacks like this have to be static to avoid a memory leak)
Member
Author
|
@leolost2605 filters should be much better now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow selecting any font instead of a toggle for just dyslexia fonts. There's lots of reasons someone might want/need a specific font.
Fixes #304
closes #238
closes #240
closes #390
closes #479
This attempts to make font selection simpler by just selecting family and we enforce our same sizes. There are filters built-in Gtk.FontDialog for language and monospace but I don't think there's any way to activate them by default?
This filters out "Noto" fonts since they're meant to avoid "tofu" chars and not to be a font you use itself