Skip to content

Internal: Fix failing phpunit tests [TMZ-1039]#646

Merged
hein-obox merged 1 commit into
mainfrom
internal/TMZ-1039-fix-phpunit
May 21, 2026
Merged

Internal: Fix failing phpunit tests [TMZ-1039]#646
hein-obox merged 1 commit into
mainfrom
internal/TMZ-1039-fix-phpunit

Conversation

@hein-obox
Copy link
Copy Markdown
Member

@hein-obox hein-obox commented May 20, 2026

✨ PR Description

1. Problem & Context

CI tests were failing due to overly complex conditional coverage logic. Simplified by removing conditional test runs and eliminating unnecessary coverage tooling.

2. What Changed (Where)

  • .github/workflows/phpunit.yml: Removed COVERAGE env var and conditional test steps; now runs single unified composer run test command
  • composer.json: Removed thor-juhasz/phpunit-coverage-check dependency and coverage-related scripts; kept yoast/phpunit-polyfills for PHP compatibility

3. How It Works

Test execution now unconditionally runs composer run test targeting the hello-elementor suite, eliminating matrix-dependent branch logic that was causing failures. Coverage checks were delegated or removed entirely.

4. Risks

Loss of coverage reporting if coverage enforcement was required downstream—verify coverage gates aren't assumed elsewhere. The yoast/phpunit-polyfills retention suggests PHP 8+ compatibility needs are still relevant; ensure no test incompatibilities emerge.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@hein-obox hein-obox merged commit 99ab994 into main May 21, 2026
42 checks passed
@hein-obox hein-obox deleted the internal/TMZ-1039-fix-phpunit branch May 21, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants