fix: Make codeowners-merge callable#2
Merged
Conversation
|
Thanks for the PR! This section of the codebase is owned by @danieljimeneznz - if they write a comment saying "LGTM" then it will be merged. |
danieljimeneznz
force-pushed
the
fix/codeowners-merge
branch
from
5b17037 to
a1799d7
Compare
Member
Author
|
lgtm |
|
Merging because @danieljimeneznz is a code-owner of all the changes - thanks! |
There was a problem hiding this comment.
Pull request overview
Adds a reusable “Codeowners Merge” workflow to this shared workflows repository, documents how consuming repos should call it, and adjusts the PR-title verification workflow trigger.
Changes:
- Document how to call the new reusable Codeowners Merge workflow from consuming repositories.
- Switch
Verify PR Titleworkflow trigger frompull_request_targettopull_request. - Add
.github/workflows/codeowners-merge.yamlas aworkflow_call-enabled reusable workflow that generates a GitHub App token and runscode-owner-self-merge.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Adds usage documentation/snippet for calling the Codeowners Merge reusable workflow. |
| .github/workflows/verify-pr-title.yaml | Changes event trigger to pull_request. |
| .github/workflows/codeowners-merge.yaml | Introduces a callable reusable workflow to perform CODEOWNERS self-merge checks using a GitHub App token. |
Comments suppressed due to low confidence (1)
.github/workflows/codeowners-merge.yaml:20
actions/checkout@v6does not appear to be a valid/published major version (the commonly used major isv4). If this version doesn’t exist, this reusable workflow will fail at runtime; consider pinning to an existing major version (or a specific tag/sha your org standardizes on).
- uses: actions/checkout@v6
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| merge-check: | ||
| if: > | ||
| github.event_name != 'issue_comment' || | ||
| github.event.issue.pull_request != '' |
Comment on lines
4
to
+6
| on: | ||
| pull_request_target: { types: [ opened ] } | ||
| issue_comment: { types: [ created ] } | ||
| pull_request_review: { types: [ submitted ] } | ||
| workflow_call: {} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.