This repository was archived by the owner on Jun 30, 2021. It is now read-only.
Encode with YUV420P, to be more compatible #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #256.
This is still suboptimal (IMHO), since we encode twice with the same options... Wouldn't it be better to do an "almost-lossless" encode while doing the x11grab (with a fixed set of options, perhaps
-crf 0 -preset ultrafast -qp 0) and letting the user decide only the encoding options of the second step (via theFFMPEG_CODEC_ARGSoption) - WDYT? If that is something desired, I can prepare a patch set with those changes.Difference in ffprobe is now:
Profile is still
High 4:4:4 Predictive- I think this is forced by the-qp 0option.PS: I saw the
FFMPEG_FINAL_CRF=0- is that still used anywhere, I didn't saw it used in the repository?