feat: resolve elide from PATH#2
Merged
Merged
Conversation
Sam Gammon (sgammon)
added
enhancement
feat: use compiler path if specified (overrides) feat: resolve `elide` from user path chore: cleanups in readme/sample project chore: move compiler ID to new constants file Signed-off-by: Sam Gammon <sam@elide.dev>
Sam Gammon (sgammon)
force-pushed
the
feat/resolve-from-path
branch
from
c089714 to
8b0eb06
Compare
Comment on lines
-18
to
+35
| open class ElideJavacCompiler() : AbstractCompiler( | ||
| public open class ElideJavacCompiler() : AbstractCompiler( |
Member
Author
There was a problem hiding this comment.
i plan to start enforcing "explicit" mode on this project eventually, so we don't break downstream users with public symbol changes. this is prep for that
Comment on lines
+83
to
+86
| private fun getElideExecutable(config: CompilerConfiguration): String = when (val executable = config.executable) { | ||
| null -> ElideLocator.locate()?.absolutePathString() | ||
| else -> executable | ||
| } ?: "elide" |
Member
Author
There was a problem hiding this comment.
slightly cleaner with a when-with-subject, also adds PATH resolution
Comment on lines
-179
to
+196
| fun parseOutput(exitCode: Int, input: List<String>): List<CompilerMessage> { | ||
| private fun parseOutput(exitCode: Int, input: List<String>): List<CompilerMessage> { |
Member
Author
There was a problem hiding this comment.
explicit mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
PATHresolution for the Elide binary, which kicks in by default; ifmaven.compiler.executableis specified, it will be used, otherwise this new logic will apply.#1 should be merged first, and then this should be rebased, before merging (or, this should be merged and that PR should be closed).
Changelog