ci: skip normal CI/CodeQL on release-please PRs#65
Merged
Conversation
Release-please PRs only touch CHANGELOG/manifest/version files and are re-validated on main after merge, so running the full test/lint/e2e/codeql suite on them just burns runners. Guard the PR-running jobs with `!startsWith(github.head_ref, 'release-please--')` (head_ref is empty on push, so main is unaffected; integration/kotlin-builder already skip all PRs). No status checks are required on main, so this doesn't block the release PR merge. Signed-off-by: Sam Gammon <sam@elide.dev>
Sam Gammon (sgammon)
requested review from
a team,
Copilot and
Dario Valdespino (darvld)
and removed request for
Copilot
Merging this PR will not alter performance
|
The previous guard keyed only on github.head_ref, which a fork PR controls — a branch named `release-please--evil` would skip CI/CodeQL on that PR. Add a same-repo condition (head.repo.full_name == github.repository) so only genuine release-please branches (which only exist on our own repo) skip; fork PRs always run the full suite. Signed-off-by: Sam Gammon <sam@elide.dev>
There was a problem hiding this comment.
Pull request overview
Adjusts GitHub Actions workflows to skip running expensive PR-only CI and CodeQL analysis for same-repo release-please--* pull requests, reducing runner usage while relying on validation after merge to main.
Changes:
- Add job-level guards to skip CI jobs for same-repo
release-please--*PR branches. - Add a similar guard to CodeQL analysis to skip same-repo
release-please--*PRs while still running onpush/scheduleand fork PRs. - Extend the existing same-repo RBE gating to also skip release-please PR branches.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds if: conditions to skip CI jobs for same-repo release-please PRs. |
| .github/workflows/codeql.yml | Adds if: condition to skip CodeQL on same-repo release-please PRs (still runs on push/schedule). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Restructure the CI/CodeQL skip conditions to "skip only when it's a same-repo release-please pull_request": `!(event_name == 'pull_request' && head.repo == this repo && startsWith(head_ref, 'release-please--'))`. GitHub expressions are null-safe so the prior form wouldn't actually fail on push/schedule, but the event_name guard is clearer and matches the repo convention (benchmarks.yml). Signed-off-by: Sam Gammon <sam@elide.dev>
Elidebot (elidebot)
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-please PRs only edit CHANGELOG/manifest/version files and are re-validated on
mainafter merge, so running the full suite on them wastes runners.Guards the PR-running jobs in
ci.yml(tests, e2e, lint, docs-freshness, rbe) andcodeql.ymlwith!startsWith(github.head_ref, 'release-please--').head_refis empty on push events, somainis unaffected;integration/kotlin-builderalready skip all PRs. No required status checks onmain, so the release PR can still merge.