Skip to content

Hide congrats confetti when not on inbox tab #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025
Merged

Hide congrats confetti when not on inbox tab #390

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0125353
Fix #123: hide congrats confetti when not on inbox tab
Francisca105 Mar 28, 2025
3dadaa9
Update Celebration component to conditionally render confetti and alt…
Francisca105 Apr 5, 2025
bdb2d32
Refactor Celebration component to remove confetti prop and simplify r…
Francisca105 Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apps/web/components/email-list/EmailList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,13 @@ export function List({
/>
) : (
<div className="mt-20">
<Celebration
message={
type === "inbox"
? "You made it to Inbox Zero!"
: "All emails handled!"
}
/>
{type === "inbox" ? (
<Celebration message={"You made it to Inbox Zero!"} />
) : (
<div className="flex items-center justify-center font-cal text-2xl text-primary">
No emails to display
</div>
)}
</div>
)}
</>
Expand Down