Bricks integration: fix slider in Bricks Extras, WPGB facet#220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 ways to eliminate an element from rendering:
$data, which is the previous way to handle the compatibility. However, it doesn't handle well with nested elements. Hence, the 2nd way:bricks/element/render, which decides whether to render an element. But it doesn't handle enqueuing scripts!This PR uses both ways to fix the issue. And also improve by ignoring elements by category: 'media', 'query', 'wordpress', 'extras' (from Bricks Extras).