feat: add root query endpoint and POST /.search#199
Merged
Conversation
Add GET / and POST /.search to query across all resource types. Introduce RootQueryHandler interface, WithRootQueryHandler server option, ValidateFilterForResourceTypes utility, and a raw Filter field on ListRequestParams. Fix filter validation to include common attributes (id, externalId, meta.*) so filters like meta.lastModified work on per-resource endpoints. Fix potential slice mutation in schema attribute appending.
97adde4 to
65d2497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GET / and POST /.search to query across all resource types. Introduce RootQueryHandler interface, WithRootQueryHandler server option, ValidateFilterForResourceTypes utility, and a raw Filter field on ListRequestParams. Fix filter validation to include common attributes (id, externalId, meta.*) so filters like meta.lastModified work on per-resource endpoints. Fix potential slice mutation in schema attribute appending.
Summary
GET /andPOST /.searchendpoints for cross-resource-type queries per RFC 7644 Sections 3.4.2.1 and 3.4.3RootQueryHandlerinterface andWithRootQueryHandler(h)server optionValidateFilterForResourceTypesutility for narrowing filters to matching resource typesFilterstring toListRequestParamsfor root queries where schema-based validation is not possiblerawResources()injectsid,externalId, andMetafields (created, lastModified, version) into root query responsesparsePaginationParamsto share count/startIndex logic between root and per-resource handlersgetFilterValidatorandschemaWithCommonnow includeCommonAttributes()so filters onmeta.lastModified,meta.resourceType,id,externalIdno longer return 400 on per-resource endpointsgetFilterValidator,ValidateFilterForResourceTypes, andschemaWithCommonto avoid mutating the original schema's backing array