fix gotip formatting check in CI#30
Merged
elithrar merged 1 commit intoadd-agents-mdfrom Feb 10, 2026
Merged
Conversation
gotip fmt -l . is invalid (go fmt doesn't accept -l). The step always exits 2, silently swallowed by continue-on-error. Use gofmt -l . via the gotip-provided PATH instead, matching the stable job's approach.
elithrar
added a commit
that referenced
this pull request
Feb 10, 2026
* add AGENTS.md, rename default branch to main * update CI matrix to Go 1.21-1.24 plus tip * fix gotip formatting check in CI (#30) gotip fmt -l . is invalid (go fmt doesn't accept -l). The step always exits 2, silently swallowed by continue-on-error. Use gofmt -l . via the gotip-provided PATH instead, matching the stable job's approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gotip fmt -l .is invalid —go fmtdoesn't accept the-lflag, so the step always exits 2. Becausecontinue-on-error: trueis set on thetest-tipjob, the failure is silently swallowed and formatting is never checked for tip.gotip fmt -l .withtest -z "$(gofmt -l .)", matching the stable jobgofmtresolves to the gotip version since line 49 already adds gotip's GOROOT/bin to PATH