Refactoring debug for respect kpatch upstream changes#16
Merged
aliceinwire merged 1 commit intomasterfrom Jun 5, 2018
Merged
Conversation
gktrk
suggested changes
Dec 20, 2017
| if debug: | ||
| bashCommand.extend(['--skip-cleanup']) | ||
| bashCommand.extend(['--debug']) | ||
| bashCommand.extend(['--dddd']) |
Contributor
There was a problem hiding this comment.
Shouldn't this be single dash, i.e. -dddd per https://github.com/dynup/kpatch/pull/760/files#diff-c4bc518fff9b8f8607f5f407c34c8809R381
debug option is now accepting multiple -d arguments dynup/kpatch#760
aliceinwire
force-pushed
the
kpatch_debug_option_changed_upstream
branch
from
37c9182 to
36d9b01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug option is now accepting multiple -d arguments
dynup/kpatch#760