Added supervisor init telemetry event#223
Conversation
Pull Request Test Coverage Report for Build 778087c8823a988031750c90b547000269a981a7-PR-223
💛 - Coveralls |
|
Hi @akoutmos! This looks good to me but I am afraid the configuration is somewhat private. We may tweak it so it mirrors our internals and that may break the dashboard. We should either expose specific information that you need or expose the user supplied map as is. |
|
I'm ok with using the user supplied map as opposed to the internal representation. It looks like the user's options are going through I'll update the PR to leverage the user options and also update the telemetry docs to include this new event. Thanks for the speedy feedback! |
|
Updated the PR to address your feedback. Let me know if there is anything else that i should adjust :). |
philss
left a comment
There was a problem hiding this comment.
Great addition!
I left one suggestion :)
|
|
||
| Broadway currently exposes following Telemetry events: | ||
|
|
||
| * `[:broadway, :supervisor, :init]` - Dispatched when the supervision tree |
There was a problem hiding this comment.
Just a nitpick: instead of supervisor, we could name this topology or pipeline for better proximity with naming from Broadway. WDYT?
There was a problem hiding this comment.
Great idea! I liked topology better and updated the PR with that one :D
|
💚 💙 💜 💛 ❤️ |
I am currently working on the PromEx Broadway plugin (akoutmos/prom_ex#39) and would like to incorporate some of the configuration details into the Broadway Grafana dashboard. Thoughts on surfacing the config from the Topology module after the supervisor is started?
If you are okay with this approach I will go through and add the necessary documentation to the telemetry events. Thanks in advance!