Skip to content

fix(ecc-utils-design): defaultInstances bug#181

Merged
anuragxxd merged 1 commit intomainfrom
fix/defaultInstances-bug
Nov 13, 2023
Merged

fix(ecc-utils-design): defaultInstances bug#181
anuragxxd merged 1 commit intomainfrom
fix/defaultInstances-bug

Conversation

@salihudickson
Copy link
Contributor

Description

This PR fixes the bug that causes false to be returned when the default instances of an array field is 0

Fixes #171

Checklist

  • My code follows the contributing guidelines of this project.
  • I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have updated the user-facing documentation to describe any new or changed behavior.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have not reduced the existing code coverage.

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2023

⚠️ No Changeset found

Latest commit: 330cc20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cloud-components ✅ Ready (Inspect) Visit Preview Nov 13, 2023 2:26pm

Copy link
Member

@anuragxxd anuragxxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@anuragxxd anuragxxd merged commit c4e8acb into main Nov 13, 2023
@anuragxxd anuragxxd deleted the fix/defaultInstances-bug branch November 13, 2023 14:36
@anuragxxd
Copy link
Member

anuragxxd commented Nov 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: template returning false if array if defaultInstances is 0

2 participants