Support preloading associations in embedded schemas from the parent schema#3965
Closed
Sleepful wants to merge 4 commits intoelixir-ecto:masterfrom
Closed
Support preloading associations in embedded schemas from the parent schema#3965Sleepful wants to merge 4 commits intoelixir-ecto:masterfrom
Sleepful wants to merge 4 commits intoelixir-ecto:masterfrom
Conversation
Sleepful
commented
Jul 29, 2022
Comment on lines
+65
to
+71
| # NOTE: this "ignore preload inner stacktrace" was quite | ||
| # misleading to me, is there something to gain from hiding | ||
| # the stacktrace like this? | ||
| rescue | ||
| e -> | ||
| # Reraise errors so we ignore the preload inner stacktrace | ||
| filter_and_reraise e, __STACKTRACE__ | ||
| filter_and_reraise(e, __STACKTRACE__) |
Member
|
We haven't run the formatter in this repo yet, so can you please submit/update the PR without the formatter changes? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements enhancement #3890
Sorry for the huge diff, I do not know if my formatter is working properly or not, I tried:
...to no avail.
There is this one bit of code hiding a stacktrace, I left a comment there, confused me a bit.
I am an Elixir newbie so I am mostly unaware of what makes "good" code.