chore: accept a counter option in prepare_query/3#4714
Open
zachdaniel wants to merge 4 commits intoelixir-ecto:masterfrom
Open
chore: accept a counter option in prepare_query/3#4714zachdaniel wants to merge 4 commits intoelixir-ecto:masterfrom
counter option in prepare_query/3#4714zachdaniel wants to merge 4 commits intoelixir-ecto:masterfrom
Conversation
zachdaniel
commented
Apr 5, 2026
zachdaniel
force-pushed
the
merge-support
branch
from
1224931 to
386f47f
Compare
josevalim
reviewed
Apr 6, 2026
Member
|
Out of curiosity what problem does this solve? |
Member
|
@zachdaniel is implementing |
josevalim
reviewed
Apr 7, 2026
josevalim
reviewed
Apr 7, 2026
josevalim
reviewed
Apr 7, 2026
| {query, params, key} = plan(query, operation, adapter) | ||
| {cast_params, dump_params} = Enum.unzip(params) | ||
| key = if query_cache?, do: key, else: :nocache | ||
| key = if query_cache?, do: {key, counter}, else: :nocache |
Member
There was a problem hiding this comment.
@zachdaniel I thought it would be better to always add the counter, to reduce the number of branches, but it seems that either using a list is wrong or we are messing with the key in an incompatible way. Can you please take a deeper look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.