Add format option for PostgreSQL explain#295
Add format option for PostgreSQL explain#295josevalim merged 1 commit intoelixir-ecto:masterfrom pawurb:explain_format
Conversation
|
Thanks @pawurb, this looks great! I only have one question: the YAML format is still returned as text while JSON returns a map. This feels a bit inconsistent to me. I wonder if instead we should introduce something like /cc @leandrocp |
|
@josevalim I'm afraid that parsing YAML would require adding another dependency. How about we stick to the text format for all the outputs and leave the parsing for the client? |
That's another route. We keep it all as text and |
Agreed, IMO that's the best option 👍🏻 |
|
Yes, looks good to me, sorry for the confusion! I think we should not provide JSON then until we figure out the Jaosn dependency, so I will remove it post-merge. Thank you! |
|
💚 💙 💜 💛 ❤️ |
This PR adds JSON and YAML format outputs to
explainfor PostgreSQL databases:Especially the
jsonformat is useful because it can be used with query visualizer tool for some advanced debugging.