Postgres/MyXQL adapters: Do not fail storage_up if the user has access to an already-created database#297
Merged
josevalim merged 1 commit intoelixir-ecto:masterfrom Jan 11, 2021
Conversation
rinpatch
force-pushed
the
fix/storage_up_no_create_database_permission
branch
2 times, most recently
from
6b71879 to
9af562e
Compare
Member
|
Thanks! Note CI is unhappy for MySQL v5.x (but note it was failing prior to this commit for MySQL v8.0 - so don't worry about this particular version). |
…s to an already-created database Closes elixir-ecto#296
rinpatch
force-pushed
the
fix/storage_up_no_create_database_permission
branch
from
9af562e to
d3e7182
Compare
Author
|
Fixed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296
I was not sure if raw SQL in the tests needs to be put into helper functions, decided to not do it since no other tests need this functionality.