Skip to content

to_exclusive#370

Merged
josevalim merged 1 commit intoelixir-ecto:masterfrom
greg-rychlewski:to_exclusive
Dec 29, 2021
Merged

to_exclusive#370
josevalim merged 1 commit intoelixir-ecto:masterfrom
greg-rychlewski:to_exclusive

Conversation

@greg-rychlewski
Copy link
Copy Markdown
Member

@greg-rychlewski greg-rychlewski commented Dec 28, 2021

Closes #336.

Introduce --to-exclusive option for mix.ecto.migrate and mix.ecto.rollback. Chose this option instead of the ones mentioned in the issue for a couple reasons:

  • Having both inclusive and exclusive options could be useful
  • The wording is not ambiguous. --target/--up-to sound to me like it should include the version I'm specifying

It's a bit verbose but this one or --to-excluding are the ones that sounded the least ambiguous to me and also let you keep the existing to behaviour.

Copy link
Copy Markdown
Member

@v0idpwn v0idpwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I like the naming as well.

@josevalim josevalim merged commit cc2decb into elixir-ecto:master Dec 29, 2021
@josevalim
Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

@n-epifanov
Copy link
Copy Markdown

Great, thanks!

@greg-rychlewski greg-rychlewski deleted the to_exclusive branch April 15, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Counterintuitive mix ecto.rollback interface

4 participants