Skip to content

Label the sandbox owner process #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

Label the sandbox owner process #697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c07032
Label the sandbox owner process
nathanl Nov 12, 2025
3c0f01b
Update lib/ecto/adapters/sql/sandbox.ex
josevalim Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/ecto/adapters/sql/sandbox.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ defmodule Ecto.Adapters.SQL.Sandbox do

{:ok, pid} =
Agent.start(fn ->
set_label({:sql_sandbox_owner, %{started_by: parent}})
{shared, opts} = Keyword.pop(opts, :shared, false)
:ok = checkout(repo, opts)

Expand Down Expand Up @@ -702,4 +703,12 @@ defmodule Ecto.Adapters.SQL.Sandbox do
defp pre_checkin(_, Connection, {conn_mod, conn_state, _in_transaction?}, _opts) do
{:ok, conn_mod, conn_state}
end

defp set_label(label) do
if function_exported?(Process, :set_label, 1) do
Process.set_label(label)
Copy link
Contributor Author

@nathanl nathanl Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't depend on a specific OTP version https://github.com/elixir-lang/elixir/blob/v1.19.2/lib/elixir/lib/process.ex#L1001-L1006

end

:ok
end
end
Loading