Reload types on unknown oid during prepare#317
Merged
Conversation
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| bootstrap_send(s, status, types, parameters, buffer, &bootstrap_sync_recv/3) | ||
| end | ||
|
|
||
| defp bootstrap_send(s, status, types, parameters, buffer, next) do |
There was a problem hiding this comment.
Function takes too many parameters (arity is 6, max is 5).
| {:ok, pid} = Postgrex.start_link(context[:options]) | ||
| assert %Postgrex.Result{num_rows: 1} = Postgrex.query!(pid, "INSERT INTO missing_oid VALUES ($1, $2)", ["missing", {1,2}]) | ||
| assert %Postgrex.Result{rows: [["missing", {1,2}]]} = Postgrex.query!(pid, "SELECT a,b FROM missing_oid", []) | ||
| assert :ok = query("INSERT INTO missing_oid VALUES ($1, $2)", ["missing", {1,2}]) |
|
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 4 commits behind the You can see more details about this review at https://ebertapp.io/github/elixir-ecto/postgrex/pulls/317. |
Member
Author
|
This is ready to go. |
Member
|
Beautiful! I love the new tests! ❤️ 💚 💙 💛 💜 |
Member
Author
|
Oh the tests can't use range because it requires 9.2 |
range requires postgresql 9.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243. This is WIP.
@mspanc can you check if this branch resolves your issue?