Retain enumeration properties when using to_rows on columnar data#14
Merged
jonatanklosko merged 3 commits intomainfrom Jun 28, 2022
Merged
Retain enumeration properties when using to_rows on columnar data#14jonatanklosko merged 3 commits intomainfrom
jonatanklosko merged 3 commits intomainfrom
Conversation
josevalim
reviewed
Jun 28, 2022
|
|
||
| def count(zipper) do | ||
| zipper.enumerables | ||
| |> Enum.reduce_while(:infinity, fn enumerable, min_count -> |
Member
There was a problem hiding this comment.
I think it is actually fair of us to assume that all columns have the same size and therefore call {:ok, Enum.count(...)} on a single column.
Contributor
Author
There was a problem hiding this comment.
We actually don't check enumerables length in something like data = %{x: [1, 2, 3, 4], y: [1, 2, 3]}, so I'd rather check all counts. Generally we can expect series to be of the same type, so if we can get count for one, we should be able to get for the others as well. I also like that this is in line with Enum/Stream zip behaviour :)
josevalim
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10.