Indent struct properties with names of reserved words properly

[cs-victor-nascimento]

Just stumbled upon this tricky one when using s %ExUnit.Test{} struct. When I try to access the 'case' property it thinks its the start of a case expression and indents the next line as if it were inside the case expression.

For example, try this (don't mind my noobines in Elixir \o/):

This may be tricky to get right. =/

Anyway, thanks for this great mode :D

[mattdeboard]

Thanks for opening this issue. I've added a failing regression test to capture this indentation bug.

[mattdeboard]

There are a couple of separate issues here:

1. Syntax highlighting. We can definitely hard-code a (symbol-start (and (not (any ".")) builtin)) regex, but I don't think that is the right solution. What we want is to eliminate this entire class of syntax highlighting problem. My first thought is that updating the elixir-rx macro to handle this might be a graceful place to start. Either that, or having a separate wrapping function that does this for every keyword.
2. Indentation. SMIE is looking at the grammar specification for case..do..end and performing the default indentation. Again, we can hard-code a fix for .case so that the next line is indented at the right level, but the right solution is to eliminate this problem entirely. A SMIE rule that looks backward for a preceding "." then adjusts the indentation appropriately is probably the right thing.

[mattdeboard]

We might want to think about updating the grammar to understand dotted notation...

[cs-victor-nascimento]

👍

Do you think its best to open 2 issues or leave it as it is?

Also, sorry I can't help much with the elisp side of things. Started reading the elisp manual but couldn't find time to practice it.

[mattdeboard]

No worries @cs-victor-nascimento just making notes for whoever reads the issue.

[mattdeboard]

And no one issue is fine.

[cs-victor-nascimento]

This seems to be fixed now 👍

You can close this one!