Skip to content

Fix highlighting hashmark in sigil #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonini merged 2 commits into from
Oct 16, 2015
Merged

Fix highlighting hashmark in sigil #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b94f636
Fix highlighting hashmark in sigil
syohex Oct 16, 2015
886aa91
Add unit test for hashmark in sigil
syohex Oct 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elixir-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ is used to limit the scan."
(when (memq start-delim '(?' ?\"))
(setq end (1+ end))
(forward-char -1))
(while (re-search-forward "[\"']" end t)
(while (re-search-forward "[\"'#]" end t)
(put-text-property (1- (point)) (point) 'syntax-table word-syntax))))))

(defun elixir-syntax-propertize-function (start end)
Expand Down
8 changes: 8 additions & 0 deletions test/elixir-mode-font-test.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,14 @@ foo
(should (eq (elixir-test-face-at 53) 'font-lock-string-face))
(should (eq (elixir-test-face-at 55) 'font-lock-string-face))))

(ert-deftest elixir-mode-syntax-table/hashmark-in-sigils ()
"Don't treat hashmark in sigils as comment"
:tags '(fontification syntax-table)
(elixir-test-with-temp-buffer
"~s(# foo)"
(should-not (eq (elixir-test-face-at 4) 'font-lock-comment-face))
(should (eq (elixir-test-face-at 6) 'font-lock-string-face))))

(provide 'elixir-mode-font-test)

;;; elixir-mode-font-test.el ends here