Skip to content
This repository was archived by the owner on Feb 9, 2021. It is now read-only.

Starting v2 Features #17

Closed
wants to merge 23 commits into from
Closed

Starting v2 Features #17

wants to merge 23 commits into from

Conversation

@bijanbwb
Copy link
Contributor

@bijanbwb bijanbwb commented Jan 13, 2018

  • Fetch, decode, and list gameplays below Elm game.
  • List player's gameplays on player show page.
  • Link from main player scoreboard to player show pages.
  • Adjust Ecto relationships (from many_to_many to has_many)
  • Sync platform content with latest book content.

bijanbwb added 21 commits January 2, 2018 22:12
@bijanbwb
Update app.js to use consistent js import syntax
5733d9f
@bijanbwb
Add images for character direction changes
ac467e7
@bijanbwb
Sync Platformer game with book content
0640c6b 
The demo application and the book had diverged slightly. This commit
should contain all the updates to the Platformer.elm file so that the
demo follows the book content. And this will allow me to push some
additional updates soon.
@bijanbwb
Generate gameplay resources
8753da4
@bijanbwb
Update player's total score on gameplay creation
e9d562c 
Not sure if it's a good idea to alias the Accounts module here since I
think the contexts are separated for a reason. But the idea is to sum
the player's total score whenever a new gameplay record is created.
@bijanbwb
Display player name with score
d735feb
@bijanbwb
Fetch gameplays
5c29d43 
This works for rendering all the gameplays, but the
http://0.0.0.0:4000/api/gameplays endpoint still needs to be fixed so
that it includes the game_id and player_id.
@bijanbwb
Link from home page to show player page
f9dfcbe
@bijanbwb
Render gameplays on player show page
c9d06c0
@bijanbwb
Update seeds
ca618e6
@bijanbwb
Fix gameplay decoder
46099f7
@bijanbwb
Guard against empty player scores section
428a585
@bijanbwb
Include gameplay data for JSON endpoint
0dfff1a
@bijanbwb
Updates for player show template
9c3fb08
@bijanbwb
Preload gameplays for players and games
d687939
@bijanbwb
Add ex_machina dependency for tests
a750171
@bijanbwb
Replace player fixtures with factories
60a1a56
@bijanbwb
Tinkering with Ecto relationships
7debd41 
Got stuck pretty bad here for a while. The good news is it seems like a
good start to be able to query for things like `player.games` and
`player.gameplays` and `game.players` and `game.gameplays`.

The schemas seem okay, but I was having a tough time figuring out how
`cast_assoc`, `build_assoc`, and `put_assoc` work. In the current state,
it looks like players and games are properly linked, but the gameplays
get created without loading the associations properly.
@bijanbwb
Add preload queries for players and games
891a5bc
@bijanbwb
Preload games and players for gameplays
2300565
@bijanbwb
Store ids in gameplay records
fd3b7ad
@bijanbwb bijanbwb changed the title Gameplay Scoring Starting v2 Features Jan 13, 2018
@bijanbwb
Copy link
Contributor Author

bijanbwb commented Jan 15, 2018

This branch is now stale, but the features originally spiked out here were merged on the following PRs:

@bijanbwb bijanbwb closed this Jan 15, 2018
@bijanbwb bijanbwb deleted the spike-gameplay-scoring branch January 15, 2018 04:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bijanbwb