Handler ErrorTracker.Integrations.Phoenix has failed and has been detached

[sevenseacat]

Trying to test out the project but I can't seem to get any errors logged. The error occurs at this line

error-tracker/lib/error_tracker.ex

Line 116 in 12da0c3

{:ok, stacktrace} = ErrorTracker.Stacktrace.new(stacktrace)

I put a sample erronous code 1 + "a" into a LiveView and got the following error:

[error] Handler ErrorTracker.Integrations.Phoenix has failed and has been detached. Class=:error
Reason={:badmatch,
 {:error,
  #Ecto.Changeset<
    action: :new,
    changes: %{
      lines: [
        #Ecto.Changeset<
          action: :insert,
          changes: %{function: "+", module: "erlang"},
          errors: [arity: {"is invalid", [type: :integer, validation: :cast]}],
          data: #ErrorTracker.Stacktrace.Line<>,
          valid?: false
        >,
        ...

I also tried changing a function call to use an invalid name (changing AshPhoenix.LiveView.page_from_params to AshPhoenix.LiveView.page_from_params1, and got a similar error:

[error] Handler ErrorTracker.Integrations.Phoenix has failed and has been detached. Class=:error
Reason={:badmatch,
 {:error,
  #Ecto.Changeset<
    action: :new,
    changes: %{
      lines: [
        #Ecto.Changeset<
          action: :insert,
          changes: %{
            function: "page_from_params1",
            module: "AshPhoenix.LiveView",
            application: "ash_phoenix"
          },
          errors: [arity: {"is invalid", [type: :integer, validation: :cast]}],
          data: #ErrorTracker.Stacktrace.Line<>,
          valid?: false
        >,
        ...

Are these not classes of errors that can be tracked at the moment?

[crbelaus]

This is interesting. For the case of 1 + "a" I get the following stacktrace:

stacktrace #=> [
  {:erlang, :+, [1, "a"], [error_info: %{module: :erl_erts_errors}]},
  {ErrorTrackerDevWeb.PageController, :call, 2, [file: ~c"dev.exs", line: 55]},
  {Phoenix.Router, :__call__, 5, [file: ~c"lib/phoenix/router.ex", line: 484]},
  {ErrorTrackerDevWeb.Endpoint, :plug_builder_call, 2,
   [file: ~c"dev.exs", line: 119]},
  {ErrorTrackerDevWeb.Endpoint, :"call (overridable 3)", 2,
   [file: ~c"deps/plug/lib/plug/debugger.ex", line: 136]},
  {ErrorTrackerDevWeb.Endpoint, :"call (overridable 4)", 2,
   [file: ~c"dev.exs", line: 119]},
  {ErrorTrackerDevWeb.Endpoint, :call, 2, [file: ~c"dev.exs", line: 119]},
  {Plug.Cowboy.Handler, :init, 2,
   [file: ~c"lib/plug/cowboy/handler.ex", line: 11]}
]

We are currently expecting an integer as the arity but for the + function we are getting [1, "a"] instead which cannot be casted. For the case of the function with invalid name I see that we are receiving the function call parameters as a list.

---

This requires further inspection but it seems that incorrect function calls report their parameters as a list. Kind of makes sense as, since the function is incorrect, there is no arity to look up.

I think that we could calculate the arity by counting the number of parameters in such cases. This should fix this problem. I need to confirm that this is an expected behaviour from Elixir though.