Fix some exceptions reporting #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zurga
suggested changes
Aug 6, 2024
odarriba
force-pushed
the
fix-some-exceptions-reporting
branch
from
ea35ce0 to
145c68d
Compare
crbelaus
approved these changes
Aug 7, 2024
Contributor
|
I've tested this with multiple kind of errors (arithmetic errors, throws, exits, case clause errors, undefined function errors, etc) and it worked perfectly 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates how some Erlang errors are handled and ensure they are stored and shown properly.
The root issue was that some Erlang errors are received as tuples and we need to convert them to Elixir exception the same way as Phoenix does on their Error pages, by calling
Exception.normalize.We also fixed storing and showing stractrace information on those cases in which no file is reported.
Closes #35