Avoid leaking any headers that appear as though may be sensitive#166
Closed
tjarratt wants to merge 1 commit intoelixir-error-tracker:mainfrom
Closed
Avoid leaking any headers that appear as though may be sensitive#166tjarratt wants to merge 1 commit intoelixir-error-tracker:mainfrom
tjarratt wants to merge 1 commit intoelixir-error-tracker:mainfrom
Conversation
Contributor
|
I'm sorry but I don't think this should be merged. We could come up with an infinite list of potential headers that could be private in some cases. Anyone's system can use custom headers at any time, so this list could also grow to infinite. At the moment we are filtering Everything else can be filtered according to each app needs with a custom ErrorTracker.Filter implementation. |
crbelaus
added a commit
that referenced
this pull request
Mar 1, 2026
We now redact headers instead of just dropping them. This allows users of the Error Tracker to know wether a header was present or not. With the previous logic it was impossible to know wether the header was dropped or not present in the first place. We also redact the `set-cookie` header so we redact outgoing cookies and not only incoming cookies as per the `cookie` header. This PR replaces #166
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ! Me again with another security related Pull Request.
As a follow-up to #160 I'd like to make the filtering of the context for errors captured from Phoenix a bit more intelligent and less hard-coded.
The major change in behaviour here is that instead of filtering out a few specific request headers, we filter out anything that looks like it could potentially be sensitive and undesirable to store in cleartext. The idea here being that it's good to be more secure by default.
I believe that a good change after this would be to make this configurable with an allowlist option, or to allow users to specify their own deny list.